Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/enums.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2859243004: Add metrics for PasswordForm submission types (Closed)
Patch Set: Test added Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« components/password_manager/core/browser/password_manager.cc ('K') | « components/password_manager/core/browser/password_manager_metrics_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/enums.xml
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 7baf69da8b7b91a334b6953c05e38b20ceace6f3..c570244fcd9d2041993c6238475eb28bb26c8eb6 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -27093,6 +27093,15 @@ from previous Chrome versions.
<int value="5" label="Generated password submission would have failed"/>
</enum>
+<enum name="PasswordSubmissionEventType" type="int">
+ <int value="0" label="No submission"/>
+ <int value="1" label="HTML form submission"/>
+ <int value="2" label="InPage navigation"/>
engedy 2017/05/09 22:02:59 nit: Same document navigation, which is the `cool`
dvadym 2017/05/10 12:10:12 Done.
+ <int value="3" label="XHR succeeded"/>
+ <int value="4" label="Frame detached"/>
+ <int value="5" label="By context menu"/>
+</enum>
+
<enum name="PasswordSyncState" type="int">
<int value="0" label="Syncing OK"/>
<int value="1" label="Read failed"/>
« components/password_manager/core/browser/password_manager.cc ('K') | « components/password_manager/core/browser/password_manager_metrics_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698