Chromium Code Reviews| Index: components/password_manager/core/browser/password_manager.cc |
| diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc |
| index 372aa78e491ad92eabb31be38ef24abd11e1104d..4d2567919a6627fba89ba38f8b6a1af5f3514621 100644 |
| --- a/components/password_manager/core/browser/password_manager.cc |
| +++ b/components/password_manager/core/browser/password_manager.cc |
| @@ -714,6 +714,9 @@ void PasswordManager::OnLoginSuccessful() { |
| client_->GetStoreResultFilter()->ReportFormLoginSuccess( |
| *provisional_save_manager_); |
| + if (provisional_save_manager_->submitted_form()) |
|
engedy
2017/05/09 22:02:59
style nit: {}
dvadym
2017/05/10 12:10:12
Done.
|
| + metrics_util::LogPasswordSuccessfulSubmissionEvent( |
|
engedy
2017/05/09 22:02:59
optional nit: Do you think it would make sense to
dvadym
2017/05/10 12:10:12
Sure, I'll do this in separate CL.
engedy
2017/05/10 13:07:42
Sounds good to me. +1 for tracking bug.
dvadym
2017/05/10 14:09:25
Even not sure whether we need tracking bug for suc
engedy
2017/05/10 14:15:56
Acknowledged.
|
| + provisional_save_manager_->submitted_form()->submission_event); |
| if (base::FeatureList::IsEnabled(features::kDropSyncCredential)) { |
| DCHECK(provisional_save_manager_->submitted_form()); |