Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2859243002: Mark VideoFullscreenOrientationLockChromeTest to RetryOnFailure (Closed)

Created:
3 years, 7 months ago by johnme
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark VideoFullscreenOrientationLockChromeTest to RetryOnFailure The final waitForContentsFullscreenState(false) occasionally times out, probably because the KEYCODE_BACK got waylaid by some kind of dialog. This patch adds @RetryOnFailure in the hopes of working around this. BUG=711005 TBR=mlamouri NOTRY=true SKIPTREECHECKS=true Review-Url: https://codereview.chromium.org/2859243002 Cr-Commit-Position: refs/heads/master@{#469345} Committed: https://chromium.googlesource.com/chromium/src/+/5f9208dc4596ac214ac8d24724c62aa33f84900a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859243002/1
3 years, 7 months ago (2017-05-04 15:47:07 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 15:53:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f9208dc4596ac214ac8d24724c6...

Powered by Google App Engine
This is Rietveld 408576698