Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2859223005: Tab Capture: Set size before changing target RWHV (Closed)

Created:
3 years, 7 months ago by miu
Modified:
3 years, 7 months ago
Reviewers:
xjz
CC:
chromium-reviews, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tab Capture: Set size before changing target RWHV Fixes a performance issue where tab capture always starts out at the maximum configured resolution, regardless of the source size. This change ensures the source size updates the capture size before the first frame is ever captured. BUG=704277 Review-Url: https://codereview.chromium.org/2859223005 Cr-Commit-Position: refs/heads/master@{#469851} Committed: https://chromium.googlesource.com/chromium/src/+/bebdfb5fde6a56eb40c7f2efc7bc0cbbcecdc41e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/media/capture/web_contents_tracker.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
miu
xjz: PTAL.
3 years, 7 months ago (2017-05-05 21:44:12 UTC) #3
xjz
lgtm
3 years, 7 months ago (2017-05-05 22:43:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859223005/1
3 years, 7 months ago (2017-05-06 02:35:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 18:53:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bebdfb5fde6a56eb40c7f2efc7bc...

Powered by Google App Engine
This is Rietveld 408576698