MIPS: Fix unaligned memory access for 64-bit types in wasm-external-refs

MIPS: Fix unaligned memory access for 64-bit types in wasm-external-refs

TEST=wasm-spec-tests/tests/set_local,wasm-spec-tests/tests/imports
BUG=

Review-Url: https://codereview.chromium.org/2859223004
Cr-Commit-Position: refs/heads/master@{#45279}
Committed: https://chromium.googlesource.com/v8/v8/+/dd9ac62cd3b900a0d1d77cd51d9af54a350e6346

[ivica.bogosavljevic, 2017-05-05 09:45:34]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[ivica.bogosavljevic, 2017-05-05 09:45:35]

PTAL

[ivica.bogosavljevic, 2017-05-11 13:05:19]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ ahaas@chromium.org, mtrofin@google.com

[ivica.bogosavljevic, 2017-05-11 13:05:19]

PTAL

[ahaas, 2017-05-11 18:05:39]

https://codereview.chromium.org/2859223004/diff/1/src/wasm/wasm-external-refs.cc
File src/wasm/wasm-external-refs.cc (right):

https://codereview.chromium.org/2859223004/diff/1/src/wasm/wasm-external-refs...
src/wasm/wasm-external-refs.cc:45: WriteUnalignedValue<int64_t>(output,
static_cast<float>(*input));
This function should an int64_t value from memory, convert it to float, and
store the result to memory. So what I would expect would be
WriteUnalignedValue<float>(output,
static_cast<float>(ReadUnalignedValue<int64_t>(input));
Are you sure you did this correctly? The same is happening several times below,
but not always.

[ivica.bogosavljevic, 2017-05-12 10:18:11]

https://codereview.chromium.org/2859223004/diff/1/src/wasm/wasm-external-refs.cc
File src/wasm/wasm-external-refs.cc (right):

https://codereview.chromium.org/2859223004/diff/1/src/wasm/wasm-external-refs...
src/wasm/wasm-external-refs.cc:45: WriteUnalignedValue<int64_t>(output,
static_cast<float>(*input));
On 2017/05/11 18:05:39, ahaas wrote:
> This function should an int64_t value from memory, convert it to float, and
> store the result to memory. So what I would expect would be
> WriteUnalignedValue<float>(output,
> static_cast<float>(ReadUnalignedValue<int64_t>(input));
> Are you sure you did this correctly? The same is happening several times
below,
> but not always.

Yes it is an error. I just don't get it why the compiler didn't complain because
I specify explicitly parameter type and there is an implicit conversion with
precision loss.

[ivica.bogosavljevic, 2017-05-12 12:00:45]

Fixed, PTAL

[ahaas, 2017-05-12 12:22:19]

lgtm

[ivica.bogosavljevic, 2017-05-12 12:35:22]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 12:35:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 13:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 13:11:03]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2017-05-12 13:15:54]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2017-05-12 13:16:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 13:17:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494594954539390,
"parent_rev": "4e43fc65f62edc33ede11cd3249ce2a43caf4a39", "commit_rev":
"dd9ac62cd3b900a0d1d77cd51d9af54a350e6346"}

[commit-bot: I haz the power, 2017-05-12 13:17:44]

Description was changed from

==========
MIPS: Fix unaligned memory access for 64-bit types in wasm-external-refs

TEST=wasm-spec-tests/tests/set_local,wasm-spec-tests/tests/imports
BUG=
==========

to

==========
MIPS: Fix unaligned memory access for 64-bit types in wasm-external-refs

TEST=wasm-spec-tests/tests/set_local,wasm-spec-tests/tests/imports
BUG=

Review-Url: https://codereview.chromium.org/2859223004
Cr-Commit-Position: refs/heads/master@{#45279}
Committed:
https://chromium.googlesource.com/v8/v8/+/dd9ac62cd3b900a0d1d77cd51d9af54a350...
==========

[commit-bot: I haz the power, 2017-05-12 13:17:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/dd9ac62cd3b900a0d1d77cd51d9af54a350...