Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2859193003: Convert constructor/iirfilter.html to new Audit (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert constructor/iirfilter.html to new Audit Manually convert constructor/iirfilter.html to use new Audit. Updated new-audionodeoptions to allow specifying constructor option when testing the default constructor. BUG=704976 TEST=constructor/iirfilter.html Review-Url: https://codereview.chromium.org/2859193003 Cr-Commit-Position: refs/heads/master@{#469489} Committed: https://chromium.googlesource.com/chromium/src/+/8bef0bcb6a3190e14abced2eefb51f37cae90abc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -82 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/iirfilter.html View 4 chunks +66 lines, -79 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/new-audionodeoptions.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL. This is the last constructor test that needs to be converted to new Audit.
3 years, 7 months ago (2017-05-04 17:27:45 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-04 19:53:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859193003/1
3 years, 7 months ago (2017-05-04 22:01:08 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:15:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bef0bcb6a3190e14abced2eefb5...

Powered by Google App Engine
This is Rietveld 408576698