Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2859173003:
Remove an obsolete TODO for removing OnWindowActivated (Closed)
|
Created:
3 years, 7 months ago by Yusuke Sato Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove an obsolete TODO for removing OnWindowActivated
We no longer have a plan to remove the function.
BUG=None
TEST=try
Review-Url: https://codereview.chromium.org/2859173003
Cr-Commit-Position: refs/heads/master@{#470040}
Committed: https://chromium.googlesource.com/chromium/src/+/17ce1506b392e50a798fe91c495f232195a2c97d
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yusukes@chromium.org changed reviewers: + cylee@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/04 22:34:20, Yusuke Sato wrote: > PTAL ping?
lgtm
The CQ bit was checked by cylee@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
yusukes@chromium.org changed reviewers: + georgesak@chromium.org
+georgesak for OWNER review. Please have a look.
On 2017/05/08 17:04:13, Yusuke Sato wrote: > +georgesak for OWNER review. Please have a look. FYI, I've been added to OWNERS https://cs.chromium.org/chromium/src/chrome/browser/memory/OWNERS So I think my LGTM is fine ?
On 2017/05/08 17:04:13, Yusuke Sato wrote: > +georgesak for OWNER review. Please have a look. FYI, I've been added to OWNERS https://cs.chromium.org/chromium/src/chrome/browser/memory/OWNERS So I think my LGTM is fine ?
On 2017/05/08 17:27:03, cylee1 wrote: > On 2017/05/08 17:04:13, Yusuke Sato wrote: > > +georgesak for OWNER review. Please have a look. > > FYI, I've been added to OWNERS > https://cs.chromium.org/chromium/src/chrome/browser/memory/OWNERS > So I think my LGTM is fine ? Oh I didn't know that. Thanks for the info. Submitting...
The CQ bit was checked by yusukes@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494265127950310, "parent_rev":
"3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2", "commit_rev":
"17ce1506b392e50a798fe91c495f232195a2c97d"}
Message was sent while issue was closed.
Description was changed from ========== Remove an obsolete TODO for removing OnWindowActivated We no longer have a plan to remove the function. BUG=None TEST=try ========== to ========== Remove an obsolete TODO for removing OnWindowActivated We no longer have a plan to remove the function. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2859173003 Cr-Commit-Position: refs/heads/master@{#470040} Committed: https://chromium.googlesource.com/chromium/src/+/17ce1506b392e50a798fe91c495f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/17ce1506b392e50a798fe91c495f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
