Correctly clamp in distance formulas

Correctly clamp in distance formulas

The clamping of the distance formulas was incorrect.  Implement
clamping according to the spec.

BUG=718069
TEST=panner-distance-clamping.html

Review-Url: https://codereview.chromium.org/2859143004
Cr-Commit-Position: refs/heads/master@{#469824}
Committed: https://chromium.googlesource.com/chromium/src/+/c8faec73855c122f94f00c54549ee6542da59e9b

[Raymond Toy, 2017-05-05 17:33:13]

Description was changed from

==========
Correctly clamp in distance formulas

The clamping of the distance formulas was incorrect.  Implement
clamping according to the spec.

BUG=718069
TEST=
==========

to

==========
Correctly clamp in distance formulas

The clamping of the distance formulas was incorrect.  Implement
clamping according to the spec.

BUG=718069
TEST=panner-distance-clamping.html
==========

[Raymond Toy, 2017-05-05 17:33:31]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-05-05 17:33:32]

PTAL

[hongchan, 2017-05-05 18:07:58]

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html
(right):

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html:201:
var xRef = Math.max(options.distance, pannerRef.refDistance);;
I see "double semicolon" here and the line 192.

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/audio/Distance.cpp (right):

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/audio/Distance.cpp:69: (dmax - dref));
Can we align this line somehow?

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/audio/Distance.cpp:91: return 0;
L.90~91 is identical to L84~L85.

[Raymond Toy, 2017-05-05 18:18:29]

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html
(right):

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html:201:
var xRef = Math.max(options.distance, pannerRef.refDistance);;
On 2017/05/05 18:07:58, hongchan wrote:
> I see "double semicolon" here and the line 192.

Done.

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/audio/Distance.cpp (right):

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/audio/Distance.cpp:69: (dmax - dref));
On 2017/05/05 18:07:58, hongchan wrote:
> Can we align this line somehow?

clang-format did that. :-(

https://codereview.chromium.org/2859143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/audio/Distance.cpp:91: return 0;
On 2017/05/05 18:07:58, hongchan wrote:
> L.90~91 is identical to L84~L85.

90-91 removed.

[hongchan, 2017-05-05 21:47:04]

lgtm

[Raymond Toy, 2017-05-05 21:52:57]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:54:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:14:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494021177714090,
"parent_rev": "67679038561e87a38508710c0058477333b40eac", "commit_rev":
"c8faec73855c122f94f00c54549ee6542da59e9b"}

[commit-bot: I haz the power, 2017-05-06 00:16:16]

Description was changed from

==========
Correctly clamp in distance formulas

The clamping of the distance formulas was incorrect.  Implement
clamping according to the spec.

BUG=718069
TEST=panner-distance-clamping.html
==========

to

==========
Correctly clamp in distance formulas

The clamping of the distance formulas was incorrect.  Implement
clamping according to the spec.

BUG=718069
TEST=panner-distance-clamping.html

Review-Url: https://codereview.chromium.org/2859143004
Cr-Commit-Position: refs/heads/master@{#469824}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8faec73855c122f94f00c54549e...
==========

[commit-bot: I haz the power, 2017-05-06 00:16:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c8faec73855c122f94f00c54549e...