Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2859123002: Move WebEntities to platform/ (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebEntities to platform/ Move the WebEntities class out of web/ and into platform/, since it has no other dependencies inside web/. BUG=712963 Review-Url: https://codereview.chromium.org/2859123002 Cr-Commit-Position: refs/heads/master@{#469288} Committed: https://chromium.googlesource.com/chromium/src/+/265b2b33274e914c1a54d292f3164dfd96840b4e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -163 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/text/WebEntities.h View 1 chunk +2 lines, -1 line 1 comment Download
A + third_party/WebKit/Source/platform/text/WebEntities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/WebEntities.h View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/web/WebEntities.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
sashab
Found as a leaf node on the new graph: https://drive.google.com/drive/u/1/folders/0B_KwtdC2J1Q6b3ZYNjVtTFIzdm8 :D Happy to debate platform/, ...
3 years, 7 months ago (2017-05-04 04:41:01 UTC) #6
slangley
On 2017/05/04 at 04:41:01, sashab wrote: > Found as a leaf node on the new ...
3 years, 7 months ago (2017-05-04 04:55:43 UTC) #7
sashab
haraken ptal, wdyt of new file location?
3 years, 7 months ago (2017-05-04 04:56:42 UTC) #9
haraken
LGTM https://codereview.chromium.org/2859123002/diff/1/third_party/WebKit/Source/platform/text/WebEntities.h File third_party/WebKit/Source/platform/text/WebEntities.h (right): https://codereview.chromium.org/2859123002/diff/1/third_party/WebKit/Source/platform/text/WebEntities.h#newcode40 third_party/WebKit/Source/platform/text/WebEntities.h:40: // FIXME: This class is wrong and needs ...
3 years, 7 months ago (2017-05-04 05:17:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859123002/1
3 years, 7 months ago (2017-05-04 05:20:28 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 06:55:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/265b2b33274e914c1a54d292f316...

Powered by Google App Engine
This is Rietveld 408576698