Issue 2859103003: Permissions/Mac: Fix RTL positions for permission decision strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859103003: Permissions/Mac: Fix RTL positions for permission decision strings. (Closed)

Created:
3 years, 7 months ago by Patti Lor

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Permissions/Mac: Fix RTL positions for permission decision strings. Support RTL for permission decision strings, wrapping strings that may be too long to fit. See https://drive.google.com/file/d/0BzEa5HU1aAqBUEl4THZuSkd5Tms/view?usp=sharing for before / after screenshots. BUG=714859 Review-Url: https://codereview.chromium.org/2841013002 Cr-Commit-Position: refs/heads/master@{#468568} (cherry picked from commit 09eed0675cc8f316344caf5ac695f140608493f6) Review-Url: https://codereview.chromium.org/2859103003 . Cr-Commit-Position: refs/branch-heads/3071@{#394} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2568622961b5a63769ea033d535d45a18053c503

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Patti Lor

3 years, 7 months ago (2017-05-04 04:47:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2568622961b5a63769ea033d535d45a18053c503.