Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2859063002: [DevTools] Enable "auto attach to sub frames" by default (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Enable "auto attach to sub frames" by default Also made "Inspect Element" open DevTools for main page now. BUG=652783 Review-Url: https://codereview.chromium.org/2859063002 Cr-Commit-Position: refs/heads/master@{#469568} Committed: https://chromium.googlesource.com/chromium/src/+/a2a5081b066eb679783fc84c7fb4b11480ffb696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-03 23:16:26 UTC) #3
pfeldman
lgtm
3 years, 7 months ago (2017-05-04 22:31:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859063002/1
3 years, 7 months ago (2017-05-05 00:16:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a2a5081b066eb679783fc84c7fb4b11480ffb696
3 years, 7 months ago (2017-05-05 01:49:16 UTC) #12
wOxxOm
3 years, 4 months ago (2017-08-15 17:10:41 UTC) #13
Message was sent while issue was closed.
Doesn't seem to auto-attach to a chrome-extension:// iframe added within a
normal web page, PTAL https://crbug.com/755515

Powered by Google App Engine
This is Rietveld 408576698