Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2859053005: Final cleanup of constructor tests (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Final cleanup of constructor tests Replace audionodeoptions.js with new-audionodeoptions.js, and update tests to use audionodeoptions.js again. No change in behavior; this is just a rename. BUG=704967 TEST= Review-Url: https://codereview.chromium.org/2859053005 Cr-Commit-Position: refs/heads/master@{#469775} Committed: https://chromium.googlesource.com/chromium/src/+/95e10b9cf74c8568b9a3e6eeb0e9464b2243b65f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -426 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/audionodeoptions.js View 1 chunk +223 lines, -179 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/biquadfilter.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/constantsource.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/delay.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/gain.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/iirfilter.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/constructor/new-audionodeoptions.js View 1 chunk +0 lines, -228 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/panner.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/waveshaper.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-05 21:15:03 UTC) #3
hongchan
lgtm
3 years, 7 months ago (2017-05-05 21:40:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053005/1
3 years, 7 months ago (2017-05-05 21:43:24 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 22:10:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95e10b9cf74c8568b9a3e6eeb0e9...

Powered by Google App Engine
This is Rietveld 408576698