Consolidate some more verify_certificate_chain_unittest/ data.

Consolidate some more verify_certificate_chain_unittest/ data.

Combine the 8 keyUsage generator scripts into a single one.
(And delete the redundant keys).

Review-Url: https://codereview.chromium.org/2859053002
Cr-Commit-Position: refs/heads/master@{#469358}
Committed: https://chromium.googlesource.com/chromium/src/+/e789943004596d5c74c20f46a4a169226f33e28a

[eroman, 2017-05-03 22:42:46]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:43:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-03 22:48:15]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:49:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-03 22:51:47]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:14:39]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-05-04 01:10:12]

lgtm

https://codereview.chromium.org/2859053002/diff/20001/net/data/verify_certifi...
File
net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/generate-chains.py
(right):

https://codereview.chromium.org/2859053002/diff/20001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/generate-chains.py:35:
for key_type in KEY_TYPES:
probably overkill, so feel free to ignore this. But you could put the keys in a
dictionary, use "for key_type in sorted(keys.keys()):"  here (sorted so it's
stable), and target.set_key(keys[key_type]) below.

[eroman, 2017-05-04 01:23:47]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-05-04 01:24:00]

https://codereview.chromium.org/2859053002/diff/20001/net/data/verify_certifi...
File
net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/generate-chains.py
(right):

https://codereview.chromium.org/2859053002/diff/20001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/target-serverauth-various-keyusages/generate-chains.py:35:
for key_type in KEY_TYPES:
On 2017/05/04 01:10:12, mattm wrote:
> probably overkill, so feel free to ignore this. But you could put the keys in
a
> dictionary, use "for key_type in sorted(keys.keys()):"  here (sorted so it's
> stable), and target.set_key(keys[key_type]) below.

Done (good idea!)

[commit-bot: I haz the power, 2017-05-04 01:24:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-05-04 01:31:57]

lgtm!

[commit-bot: I haz the power, 2017-05-04 02:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 02:28:43]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-05-04 16:31:21]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-04 16:31:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 16:40:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493915481826770,
"parent_rev": "519f83ea3b9d9d99fb1057f2d388fd3d834545f3", "commit_rev":
"e789943004596d5c74c20f46a4a169226f33e28a"}

[commit-bot: I haz the power, 2017-05-04 16:42:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493915481826770,
"parent_rev": "519f83ea3b9d9d99fb1057f2d388fd3d834545f3", "commit_rev":
"e789943004596d5c74c20f46a4a169226f33e28a"}

[commit-bot: I haz the power, 2017-05-04 16:42:38]

Description was changed from

==========
Consolidate some more verify_certificate_chain_unittest/ data.

Combine the 8 keyUsage generator scripts into a single one.
(And delete the redundant keys).
==========

to

==========
Consolidate some more verify_certificate_chain_unittest/ data.

Combine the 8 keyUsage generator scripts into a single one.
(And delete the redundant keys).

Review-Url: https://codereview.chromium.org/2859053002
Cr-Commit-Position: refs/heads/master@{#469358}
Committed:
https://chromium.googlesource.com/chromium/src/+/e789943004596d5c74c20f46a4a1...
==========

[commit-bot: I haz the power, 2017-05-04 16:42:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e789943004596d5c74c20f46a4a1...