Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2858993002: Use constexpr TaskTraits constructor in chromecast. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in chromecast. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in chromecast. BUG=713683 R=gab@chromium.org TBR=alokp@chromium.org Review-Url: https://codereview.chromium.org/2858993002 Cr-Commit-Position: refs/heads/master@{#469112} Committed: https://chromium.googlesource.com/chromium/src/+/eaaac9264a92ecd849a00b5eec536af36a305afe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chromecast/browser/url_request_context_factory.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:19:06 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:19:09 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:36:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858993002/1
3 years, 7 months ago (2017-05-03 20:44:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 20:49:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eaaac9264a92ecd849a00b5eec53...

Powered by Google App Engine
This is Rietveld 408576698