Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2858983003: Prune ComputeVisibleSelectionInDOMTreeDeprecated from ContextMenuClientImpl (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from ContextMenuClientImpl This patch prunes a call site of the deprecated function, which is safe because layout is already clean there, updated in a hit test in ContextMenuClientImpl::ShowContextMenu. BUG=698633 TEST=n/a; no behavioral changes Review-Url: https://codereview.chromium.org/2858983003 Cr-Commit-Position: refs/heads/master@{#469933} Committed: https://chromium.googlesource.com/chromium/src/+/d222098b62d82870fe150202a44fa6734403b43f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-08 02:47:25 UTC) #7
tkent
lgtm
3 years, 7 months ago (2017-05-08 02:59:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858983003/1
3 years, 7 months ago (2017-05-08 06:55:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:11:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d222098b62d82870fe150202a44f...

Powered by Google App Engine
This is Rietveld 408576698