Fade out overlay scrollbar after page load

Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with
opacity>0. We
used to call SAC::DidScrollUpdate - LTI::UpdateScrollbars to fade out
when RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at
https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call
SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858973002
Cr-Commit-Position: refs/heads/master@{#469425}
Committed: https://chromium.googlesource.com/chromium/src/+/b14926c905396fbeb0a77bfc6cce569c8a35fa5f

[chaopeng, 2017-05-03 19:22:02]

Description was changed from

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when initialization.


```
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
==========

to

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when initialization.


```
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-05-03 19:22:43]

Description was changed from

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when initialization.


```
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when initialization.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-05-03 19:23:25]

Description was changed from

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when initialization.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when
RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-05-03 19:24:03]

Description was changed from

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with opacity>0. We
used to call LayerTreeImpl::UpdateScrollbars to fade out when
RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with
opacity>0. We
used to call SAC::DidScrollUpdate - LTI::UpdateScrollbars to fade out
when RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at
https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call
SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-05-03 19:24:25]

chaopeng@chromium.org changed reviewers:
+ weiliangc@chromium.org

[chaopeng, 2017-05-03 19:24:25]

PTAL. Thank you.

[weiliangc, 2017-05-04 18:34:45]

lgtm

[chaopeng, 2017-05-04 18:39:38]

The CQ bit was checked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:40:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:36:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493923178956120, "parent_rev":
"5b95074ff70c578c5eef6f1201f23acec24f29c8", "commit_rev":
"b14926c905396fbeb0a77bfc6cce569c8a35fa5f"}

[commit-bot: I haz the power, 2017-05-04 19:36:35]

Description was changed from

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with
opacity>0. We
used to call SAC::DidScrollUpdate - LTI::UpdateScrollbars to fade out
when RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at
https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call
SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fade out overlay scrollbar after page load

This issue is caused by Aura Overlay Scrollbar is created with
opacity>0. We
used to call SAC::DidScrollUpdate - LTI::UpdateScrollbars to fade out
when RegisterScrollLayer.


```
#2 0x7f23d0dfe1ea cc::LayerTreeImpl::UpdateScrollbars()
#3 0x7f23d0dfd999 cc::LayerTreeImpl::DidUpdateScrollState()
#4 0x7f23d0e07231 cc::LayerTreeImpl::RegisterScrollLayer()
```

But we remove ScrollbarAnimationController::DidScrollUpdate call in
UpdateScrollbars at
https://crrev.com/697a467f819ce09da5209a3df13b8b92f33e35a4.
Then Overlay Scrollbar can not fade out until we have real scroll.

In this patch, we apply set_needs_show_scrollbars(true) to the layer in
LayerTreeImpl::RegisterScrollLayer that will let
LTI::HandleScrollbarShowRequestsFromMain pickup and call
SAC::DidScrollUpdate.

For cc_unittest, remove set_needs_show_scrollbars call in
LayerTreeHostImplTestScrollbarAnimation.* and
LayerTreeHostImplTest.ScrollbarVisibilityChangeCausesRedrawAndCommit.

BUG=717222
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2858973002
Cr-Commit-Position: refs/heads/master@{#469425}
Committed:
https://chromium.googlesource.com/chromium/src/+/b14926c905396fbeb0a77bfc6cce...
==========

[commit-bot: I haz the power, 2017-05-04 19:36:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b14926c905396fbeb0a77bfc6cce...

[chaopeng, 2017-05-05 18:06:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2863153002/ by chaopeng@chromium.org.

The reason for reverting is: Revert for regression

Details: https://bugs.chromium.org/p/chromium/issues/detail?id=718863.