third_party/WebKit/Source/core/page/PagePopupSupplement.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

diff --git a/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp b/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

index 59c712df3920af998ddbb385042dca419967b282..18c074333d47d6c9de373baa81d69b7d0d43141e 100644

--- a/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

+++ b/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

@@ -64,7 +64,7 @@ void PagePopupSupplement::Dispose() {

void PagePopupSupplement::Install(LocalFrame& frame,

PagePopup& popup,

PagePopupClient* popup_client) {

- ASSERT(popup_client);

+ DCHECK(popup_client);

ProvideTo(frame, SupplementName(),

new PagePopupSupplement(frame, popup, popup_client));

}