Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/core/page/PagePopupSupplement.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 return controller_; 57 return controller_;
58 } 58 }
59 59
60 void PagePopupSupplement::Dispose() { 60 void PagePopupSupplement::Dispose() {
61 controller_->ClearPagePopupClient(); 61 controller_->ClearPagePopupClient();
62 } 62 }
63 63
64 void PagePopupSupplement::Install(LocalFrame& frame, 64 void PagePopupSupplement::Install(LocalFrame& frame,
65 PagePopup& popup, 65 PagePopup& popup,
66 PagePopupClient* popup_client) { 66 PagePopupClient* popup_client) {
67 ASSERT(popup_client); 67 DCHECK(popup_client);
68 ProvideTo(frame, SupplementName(), 68 ProvideTo(frame, SupplementName(),
69 new PagePopupSupplement(frame, popup, popup_client)); 69 new PagePopupSupplement(frame, popup, popup_client));
70 } 70 }
71 71
72 void PagePopupSupplement::Uninstall(LocalFrame& frame) { 72 void PagePopupSupplement::Uninstall(LocalFrame& frame) {
73 PagePopupSupplement::From(frame).Dispose(); 73 PagePopupSupplement::From(frame).Dispose();
74 frame.RemoveSupplement(SupplementName()); 74 frame.RemoveSupplement(SupplementName());
75 } 75 }
76 76
77 DEFINE_TRACE(PagePopupSupplement) { 77 DEFINE_TRACE(PagePopupSupplement) {
78 visitor->Trace(controller_); 78 visitor->Trace(controller_);
79 Supplement<LocalFrame>::Trace(visitor); 79 Supplement<LocalFrame>::Trace(visitor);
80 } 80 }
81 81
82 } // namespace blink 82 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/PagePopupController.cpp ('k') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698