Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
index afae3379d812a0e58b55285fefee55527008d46f..de6c24500a95b46123a4d1553d09ac8012806b2c 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
@@ -102,7 +102,7 @@ BuildObjectForAnimationEffect(KeyframeEffectReadOnly* effect,
if (is_transition) {
// Obtain keyframes and convert keyframes back to delay
- ASSERT(effect->Model()->IsKeyframeEffectModel());
+ DCHECK(effect->Model()->IsKeyframeEffectModel());
const KeyframeEffectModelBase* model =
ToKeyframeEffectModelBase(effect->Model());
Vector<RefPtr<Keyframe>> keyframes =
@@ -281,7 +281,7 @@ blink::Animation* InspectorAnimationAgent::AnimationClone(
if (!id_to_animation_clone_.at(id)) {
KeyframeEffectReadOnly* old_effect =
ToKeyframeEffectReadOnly(animation->effect());
- ASSERT(old_effect->Model()->IsKeyframeEffectModel());
+ DCHECK(old_effect->Model()->IsKeyframeEffectModel());
KeyframeEffectModelBase* old_model =
ToKeyframeEffectModelBase(old_effect->Model());
EffectModel* new_model = nullptr;
@@ -535,7 +535,7 @@ void InspectorAnimationAgent::DidClearDocumentOfWindowObject(
if (!state_->booleanProperty(AnimationAgentState::animationAgentEnabled,
false))
return;
- ASSERT(frame->GetDocument());
+ DCHECK(frame->GetDocument());
frame->GetDocument()->Timeline().SetPlaybackRate(
ReferenceTimeline().PlaybackRate());
}

Powered by Google App Engine
This is Rietveld 408576698