Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
diff --git a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
index 50cc4f7817369dd9554f1e89f567c67f87557dd6..56ab672d0c3ebd56acd66ae2c9e3f7567268d67e 100644
--- a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
+++ b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
@@ -69,7 +69,7 @@ class FrontendMenuProvider final : public ContextMenuProvider {
~FrontendMenuProvider() override {
// Verify that this menu provider has been detached.
- ASSERT(!devtools_host_);
+ DCHECK(!devtools_host_);
}
DEFINE_INLINE_VIRTUAL_TRACE() {
@@ -117,7 +117,7 @@ DevToolsHost::DevToolsHost(InspectorFrontendClient* client,
menu_provider_(nullptr) {}
DevToolsHost::~DevToolsHost() {
- ASSERT(!client_);
+ DCHECK(!client_);
}
DEFINE_TRACE(DevToolsHost) {
@@ -209,7 +209,7 @@ void DevToolsHost::ShowContextMenu(LocalFrame* target_frame,
float x,
float y,
const Vector<ContextMenuItem>& items) {
- ASSERT(frontend_frame_);
+ DCHECK(frontend_frame_);
FrontendMenuProvider* menu_provider =
FrontendMenuProvider::Create(this, items);
menu_provider_ = menu_provider;

Powered by Google App Engine
This is Rietveld 408576698