Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2858943003: [CrOS Tether] Add disconnect handling to NetworkConnectionHandler::TetherDelegate. (Closed)

Created:
3 years, 7 months ago by Kyle Horimoto
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, stevenjb+watch_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Add disconnect handling to NetworkConnectionHandler::TetherDelegate. BUG=672263 Review-Url: https://codereview.chromium.org/2858943003 Cr-Commit-Position: refs/heads/master@{#469267} Committed: https://chromium.googlesource.com/chromium/src/+/d46b48bf70df88eeced7ed8d4ea6463bc7920601

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : hansberry@ comment. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -43 lines) Patch
M chromeos/components/tether/network_connection_handler_tether_delegate.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc View 1 4 chunks +16 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_connect_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 1 4 chunks +18 lines, -3 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M chromeos/network/network_connection_handler_impl.cc View 1 2 chunks +13 lines, -1 line 0 comments Download
M chromeos/network/network_connection_handler_impl_unittest.cc View 1 19 chunks +117 lines, -26 lines 0 comments Download
M chromeos/network/network_profile_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Kyle Horimoto
3 years, 7 months ago (2017-05-03 19:36:04 UTC) #2
Ryan Hansberry
lgtm
3 years, 7 months ago (2017-05-04 02:10:49 UTC) #4
stevenjb
lgtm
3 years, 7 months ago (2017-05-04 03:22:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858943003/80001
3 years, 7 months ago (2017-05-04 03:43:08 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 04:18:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d46b48bf70df88eeced7ed8d4ea6...

Powered by Google App Engine
This is Rietveld 408576698