Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2858913002: Simplify the SVGGraphicsElement ...CTM methods (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the SVGGraphicsElement ...CTM methods GetCTM() only has a single caller, so can be trivially folded. Similarly GetScreenCTM which has one kAllowStyleUpdate and one kDisallowStyleUpdate, so it can be folded while hoisting the call to update style and layout. This means that there are no longer a collision between internal methods and the ones exposed in the DOM, so the "...FromJavascript" suffixes can be dropped. Review-Url: https://codereview.chromium.org/2858913002 Cr-Commit-Position: refs/heads/master@{#469055} Committed: https://chromium.googlesource.com/chromium/src/+/9b15a04b5406ec7b03a525aed953c804ff15813e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 2 chunks +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 7 months ago (2017-05-03 13:02:19 UTC) #4
Stephen Chennney
Took me a while to verify, but yes, lgtm.
3 years, 7 months ago (2017-05-03 18:21:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858913002/1
3 years, 7 months ago (2017-05-03 18:48:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:55:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b15a04b5406ec7b03a525aed953...

Powered by Google App Engine
This is Rietveld 408576698