Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2858903004: Add coordinator for search widget in showcase. (Closed)

Created:
3 years, 7 months ago by lody
Modified:
3 years, 7 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, lpromero+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add coordinator for search widget in showcase. BUG=622743 Review-Url: https://codereview.chromium.org/2858903004 Cr-Commit-Position: refs/heads/master@{#470880} Committed: https://chromium.googlesource.com/chromium/src/+/60c4e93feefc319b6f4daee43576a5906a971efd

Patch Set 1 #

Patch Set 2 : deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M ios/showcase/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 chunk +1 line, -1 line 0 comments Download
A ios/showcase/widget/BUILD.gn View 1 1 chunk +16 lines, -0 lines 0 comments Download
A ios/showcase/widget/sc_search_widget_coordinator.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/showcase/widget/sc_search_widget_coordinator.mm View 1 chunk +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (14 generated)
lody
Please review. This gives a background that makes the widget's (black) ui elements visible. Also ...
3 years, 7 months ago (2017-05-04 12:12:05 UTC) #2
lpromero
lgtm LGTM! At some point, you can also improve your code coverage by adding EG ...
3 years, 7 months ago (2017-05-04 12:18:34 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2858253002 Patch 1). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-04 12:18:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858903004/20001
3 years, 7 months ago (2017-05-10 14:03:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450167)
3 years, 7 months ago (2017-05-10 16:34:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858903004/20001
3 years, 7 months ago (2017-05-11 08:44:42 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 08:49:41 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60c4e93feefc319b6f4daee43576...

Powered by Google App Engine
This is Rietveld 408576698