|
|
DescriptionSplit WebFrameSerializerSanitizationTest into its own file.
As WebFrameSerializerSanitizationTest grew much and in isolation of its parent
WebFrameSerializerTest it makes more sense to have it on its own separate test
file.
BUG=672313
Review-Url: https://codereview.chromium.org/2858873007
Cr-Commit-Position: refs/heads/master@{#470848}
Committed: https://chromium.googlesource.com/chromium/src/+/6d1d4e9207ec3f17854b037d1582b7568b42d4d4
Patch Set 1 #Patch Set 2 : Rebase. #
Total comments: 1
Patch Set 3 : Rebase. #
Messages
Total messages: 35 (19 generated)
The CQ bit was checked by carlosk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
carlosk@chromium.org changed reviewers: + dcheng@chromium.org, jianli@chromium.org
jianli@, dcheng@: PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
carlosk@chromium.org changed reviewers: + lukasza@chromium.org - dcheng@chromium.org
lukasza@: PTAL Replacing -dcheng@ with +lukasza@ who reviewed the previous CL in the series of WebFrameSerializerTest changes.
carlosk@chromium.org changed reviewers: + dcheng@chromium.org
dcheng@: PTAL at BUILD.gn. Oh well... Finally I was missing a reviewer for BUILD.gn . :)
LGTM https://codereview.chromium.org/2858873007/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp (right): https://codereview.chromium.org/2858873007/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp:33: #include "core/exported/WebViewBase.h" Nit: I think this can also be removed
lgtm
lgtm
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by carlosk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lukasza@chromium.org, jianli@chromium.org, dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2858873007/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494472208085750, "parent_rev": "5107b8dc6ef983872e59f544f14fb68434025cf0", "commit_rev": "6d1d4e9207ec3f17854b037d1582b7568b42d4d4"}
Message was sent while issue was closed.
Description was changed from ========== Split WebFrameSerializerSanitizationTest into its own file. As WebFrameSerializerSanitizationTest grew much and in isolation of its parent WebFrameSerializerTest it makes more sense to have it on its own separate test file. BUG=672313 ========== to ========== Split WebFrameSerializerSanitizationTest into its own file. As WebFrameSerializerSanitizationTest grew much and in isolation of its parent WebFrameSerializerTest it makes more sense to have it on its own separate test file. BUG=672313 Review-Url: https://codereview.chromium.org/2858873007 Cr-Commit-Position: refs/heads/master@{#470848} Committed: https://chromium.googlesource.com/chromium/src/+/6d1d4e9207ec3f17854b037d1582... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6d1d4e9207ec3f17854b037d1582... |