Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2858873007: Split WebFrameSerializerSanitizationTest into its own file. (Closed)

Created:
3 years, 7 months ago by carlosk
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split WebFrameSerializerSanitizationTest into its own file. As WebFrameSerializerSanitizationTest grew much and in isolation of its parent WebFrameSerializerTest it makes more sense to have it on its own separate test file. BUG=672313 Review-Url: https://codereview.chromium.org/2858873007 Cr-Commit-Position: refs/heads/master@{#470848} Committed: https://chromium.googlesource.com/chromium/src/+/6d1d4e9207ec3f17854b037d1582b7568b42d4d4

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -409 lines) Patch
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/web/tests/WebFrameSerializerSanitizationTest.cpp View 1 2 4 chunks +17 lines, -125 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 1 2 7 chunks +3 lines, -284 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
carlosk
jianli@, dcheng@: PTAL.
3 years, 7 months ago (2017-05-06 00:23:36 UTC) #4
carlosk
lukasza@: PTAL Replacing -dcheng@ with +lukasza@ who reviewed the previous CL in the series of ...
3 years, 7 months ago (2017-05-06 00:47:40 UTC) #8
carlosk
dcheng@: PTAL at BUILD.gn. Oh well... Finally I was missing a reviewer for BUILD.gn . ...
3 years, 7 months ago (2017-05-06 00:56:34 UTC) #10
dcheng
LGTM https://codereview.chromium.org/2858873007/diff/20001/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp File third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp (right): https://codereview.chromium.org/2858873007/diff/20001/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp#newcode33 third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp:33: #include "core/exported/WebViewBase.h" Nit: I think this can also ...
3 years, 7 months ago (2017-05-06 01:17:00 UTC) #11
Łukasz Anforowicz
lgtm
3 years, 7 months ago (2017-05-08 15:54:03 UTC) #12
jianli
lgtm
3 years, 7 months ago (2017-05-09 23:45:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873007/20001
3 years, 7 months ago (2017-05-09 23:47:19 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/264410) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 23:55:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873007/40001
3 years, 7 months ago (2017-05-10 01:04:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 03:06:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873007/40001
3 years, 7 months ago (2017-05-10 03:54:27 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449548)
3 years, 7 months ago (2017-05-10 07:21:37 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873007/40001
3 years, 7 months ago (2017-05-10 21:44:17 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450825)
3 years, 7 months ago (2017-05-11 00:12:15 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873007/40001
3 years, 7 months ago (2017-05-11 03:11:33 UTC) #32
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 06:38:12 UTC) #35
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6d1d4e9207ec3f17854b037d1582...

Powered by Google App Engine
This is Rietveld 408576698