Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2858873002: [SPv2] Refactor PaintInvalidator to be multicol-ready. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PaintInvalidator to be multicol-ready. BUG=648274 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2858873002 Cr-Commit-Position: refs/heads/master@{#469106} Committed: https://chromium.googlesource.com/chromium/src/+/3a882470d81dff3f3aa4e6c64838f6dbe26f9509

Patch Set 1 #

Patch Set 2 : none #

Total comments: 6

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -54 lines) Patch
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FindPaintOffsetAndVisualRectNeedingUpdate.h View 1 3 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 2 5 chunks +17 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 9 chunks +49 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
chrishtr
3 years, 7 months ago (2017-05-03 16:41:04 UTC) #4
Xianzhu
lgtm https://codereview.chromium.org/2858873002/diff/20001/third_party/WebKit/Source/core/paint/PaintInvalidator.h File third_party/WebKit/Source/core/paint/PaintInvalidator.h (right): https://codereview.chromium.org/2858873002/diff/20001/third_party/WebKit/Source/core/paint/PaintInvalidator.h#newcode119 third_party/WebKit/Source/core/paint/PaintInvalidator.h:119: const PaintPropertyTreeBuilderFragmentContext* tree_builder_context_; How about "= nullptr" to ...
3 years, 7 months ago (2017-05-03 17:29:44 UTC) #5
chrishtr
https://codereview.chromium.org/2858873002/diff/20001/third_party/WebKit/Source/core/paint/PaintInvalidator.h File third_party/WebKit/Source/core/paint/PaintInvalidator.h (right): https://codereview.chromium.org/2858873002/diff/20001/third_party/WebKit/Source/core/paint/PaintInvalidator.h#newcode119 third_party/WebKit/Source/core/paint/PaintInvalidator.h:119: const PaintPropertyTreeBuilderFragmentContext* tree_builder_context_; On 2017/05/03 at 17:29:44, Xianzhu wrote: ...
3 years, 7 months ago (2017-05-03 18:04:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858873002/40001
3 years, 7 months ago (2017-05-03 18:05:36 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 20:27:40 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3a882470d81dff3f3aa4e6c64838...

Powered by Google App Engine
This is Rietveld 408576698