Loosen type check on runZoned errorHandler

Loosen type check on runZoned errorHandler

R=floitsch@google.com, lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/d5ecaf108871d906ca372d8b66c3e1f6835ebd1d

[vsm, 2017-05-03 01:35:37]

vsm@google.com changed reviewers:
+ floitsch@google.com, lrn@google.com

[vsm, 2017-05-03 01:35:48]

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (left):

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart#old...
sdk/lib/async/zone.dart:1441: if (onError is ZoneBinaryCallback<R, Object,
StackTrace>) {
We're failing this is-check now when onError is a (Object, [StackTrace]) =>
Void.  That's causing us to fall into the runUnary path and report suboptimal
errors on internal tests.

[Lasse Reichstein Nielsen, 2017-05-03 05:55:26]

LGTM, but wait to see if Florian can see a problem.

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (left):

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart#old...
sdk/lib/async/zone.dart:1441: if (onError is ZoneBinaryCallback<R, Object,
StackTrace>) {
This is another case where `void` as a type parameter would more precisely fix
the problem. We should make a list of these so we can fix them back when that
becomes an option.

[floitsch, 2017-05-03 09:48:12]

LGTM.

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (left):

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart#old...
sdk/lib/async/zone.dart:1441: if (onError is ZoneBinaryCallback<R, Object,
StackTrace>) {
On 2017/05/03 05:55:26, Lasse Reichstein Nielsen wrote:
> This is another case where `void` as a type parameter would more precisely fix
> the problem. We should make a list of these so we can fix them back when that
> becomes an option.

Agreed with Lasse: There should at the very least be a TODO. Look at the other
TODOs in the file and add a similar one.

[vsm, 2017-05-03 12:29:56]

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (left):

https://codereview.chromium.org/2858843002/diff/1/sdk/lib/async/zone.dart#old...
sdk/lib/async/zone.dart:1441: if (onError is ZoneBinaryCallback<R, Object,
StackTrace>) {
On 2017/05/03 09:48:11, floitsch wrote:
> On 2017/05/03 05:55:26, Lasse Reichstein Nielsen wrote:
> > This is another case where `void` as a type parameter would more precisely
fix
> > the problem. We should make a list of these so we can fix them back when
that
> > becomes an option.
> 
> Agreed with Lasse: There should at the very least be a TODO. Look at the other
> TODOs in the file and add a similar one.

Done.

[vsm, 2017-05-03 12:30:32]

Description was changed from

==========
Loosen type check on runZoned errorHandler
==========

to

==========
Loosen type check on runZoned errorHandler

R=floitsch@google.com, lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d5ecaf108871d906ca372d8b66c3e1f6835ebd1d
==========

[vsm, 2017-05-03 12:30:34]

Committed patchset #2 (id:10001) manually as
d5ecaf108871d906ca372d8b66c3e1f6835ebd1d (presubmit successful).