Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: sdk/lib/async/zone.dart

Issue 2858843002: Loosen type check on runZoned errorHandler (Closed)
Patch Set: Add todo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/zone.dart
diff --git a/sdk/lib/async/zone.dart b/sdk/lib/async/zone.dart
index 33cc592a4581ee22a2ae0d8182b1837eba3d82fa..573603627f24ad056ffbb04ce72c4feeaded51d2 100644
--- a/sdk/lib/async/zone.dart
+++ b/sdk/lib/async/zone.dart
@@ -1438,7 +1438,8 @@ R runZoned<R>(R body(),
errorHandler = (Zone self, ZoneDelegate parent, Zone zone, error,
StackTrace stackTrace) {
try {
- if (onError is ZoneBinaryCallback<R, Object, StackTrace>) {
+ // TODO(floitsch): the return type should be 'void'.
+ if (onError is ZoneBinaryCallback<dynamic, Object, StackTrace>) {
return self.parent.runBinary(onError, error, stackTrace);
}
return self.parent.runUnary(onError, error);
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698