Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2858823002: Move @TargetApi annotation to AndroidBatteryManagerWrapper (Closed)

Created:
3 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, timvolodine, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move @TargetApi annotation to AndroidBatteryManagerWrapper BatteryStatusManager.updateBatteryStatusForLollipop only calls the Android L+ API BatteryManager.getIntProperty through AndroidBatteryManagerWrapper so this annotation should be moved there. BUG=635567 Review-Url: https://codereview.chromium.org/2858823002 Cr-Commit-Position: refs/heads/master@{#468865} Committed: https://chromium.googlesource.com/chromium/src/+/50836ea0c36923be03cbb2dcb4d80a59644b3912

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 3 chunks +1 line, -3 lines 2 comments Download

Messages

Total messages: 12 (7 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 7 months ago (2017-05-03 00:29:03 UTC) #2
mcasas
lgtm https://codereview.chromium.org/2858823002/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java File device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java (right): https://codereview.chromium.org/2858823002/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java#newcode54 device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:54: static class AndroidBatteryManagerWrapper { We could also put ...
3 years, 7 months ago (2017-05-03 00:47:20 UTC) #5
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2858823002/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java File device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java (right): https://codereview.chromium.org/2858823002/diff/1/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java#newcode54 device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:54: static class AndroidBatteryManagerWrapper { On 2017/05/03 00:47:20, mcasas wrote: ...
3 years, 7 months ago (2017-05-03 01:07:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858823002/1
3 years, 7 months ago (2017-05-03 01:08:48 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:54:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50836ea0c36923be03cbb2dcb4d8...

Powered by Google App Engine
This is Rietveld 408576698