Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2858813002: [Chromoting] Use ProcessStatsSender in host process

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use ProcessStatsSender in host process This is part of the change in host side to send process resourece usage information to the client. It contains, 1. Start a new channel (proc_stats) to dedicate sending process resource usage. The change is mainly in ProcessStatsDispatcher class. 2. ConnectionToClient::stats_stub(). Returns a ProcessStatsStub to deliver the information. WebRtcConnectionToClient uses ProcessStatsDispatcher, other implementations returns nullptr or FakeProcessStatsDispatcher. 3. ClientSession starts ProcessStatsSender in OnConnectionAuthenticated() and stops it in OnConnectionClosed(). A coming change will forward the process usage from Desktop Process to Network Process. BUG=650926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -60 lines) Patch
M remoting/base/constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/client_session.h View 3 chunks +8 lines, -0 lines 0 comments Download
M remoting/host/client_session.cc View 6 chunks +31 lines, -2 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M remoting/host/desktop_environment_options.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M remoting/host/host_session_options.h View 1 chunk +10 lines, -1 line 0 comments Download
M remoting/host/host_session_options.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M remoting/host/host_session_options_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M remoting/host/process_stats_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/process_stats_sender.cc View 1 chunk +17 lines, -2 lines 0 comments Download
M remoting/host/process_stats_sender_unittest.cc View 6 chunks +16 lines, -44 lines 0 comments Download
M remoting/protocol/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/protocol/connection_to_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/protocol/fake_connection_to_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/protocol/fake_connection_to_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A remoting/protocol/fake_process_stats_stub.h View 1 chunk +34 lines, -0 lines 0 comments Download
A remoting/protocol/fake_process_stats_stub.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M remoting/protocol/ice_connection_to_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/ice_connection_to_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A remoting/protocol/process_stats_dispatcher.h View 1 chunk +41 lines, -0 lines 0 comments Download
A remoting/protocol/process_stats_dispatcher.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M remoting/protocol/process_stats_stub.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/webrtc_connection_to_client.h View 3 chunks +3 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_connection_to_client.cc View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
Hzj_jie
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 00:09:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858813002/1
3 years, 7 months ago (2017-05-03 00:09:47 UTC) #2
Hzj_jie
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 00:30:59 UTC) #3
Hzj_jie
Patchset #1 (id:1) has been deleted
3 years, 7 months ago (2017-05-03 00:31:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858813002/20001
3 years, 7 months ago (2017-05-03 00:31:20 UTC) #5
Hzj_jie
Description was changed from ========== [Chromoting] Use ProcessStatsSender in host process BUG=650926 ========== to ========== ...
3 years, 7 months ago (2017-05-03 00:32:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 02:11:54 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-03 02:11:55 UTC) #8
Hzj_jie
zijiehe@chromium.org changed reviewers: + jamiewalch@chromium.org, joedow@chromium.org
3 years, 7 months ago (2017-05-03 06:07:41 UTC) #9
Hzj_jie
3 years, 7 months ago (2017-05-03 18:57:45 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698