third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js - Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js

Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback (Closed)

Patch Set: Address Xianzhu's review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js ('k') | third_party/WebKit/PerformanceTests/Canvas/toBlob_duration.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js

diff --git a/third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js b/third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js

index 21c3fe11d5bf7597517a68c9d009a5bb17787b3d..34843e85db997a4bb7b3219ca30257198a87b549 100644

--- a/third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js

+++ b/third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js

@@ -9,14 +9,18 @@

var CanvasRunner = {};

CanvasRunner.start = function (test) {

- PerfTestRunner.prepareToMeasureValuesAsync({unit: 'runs/s',

- description: test.description, done: testDone});

- if (!test.doRun) {

- CanvasRunner.logFatalError("doRun must be set.");

- return;

- }

- currentTest = test;

- runTest();

+ PerfTestRunner.startMeasureValuesAsync({

+ unit: 'runs/s',

+ description: test.description,

+ done: testDone,

+ run: function() {

+ if (!test.doRun) {

+ CanvasRunner.logFatalError("doRun must be set.");

+ return;

+ }

+ currentTest = test;

+ runTest();

+ }});

}

function runTest() {