third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js - Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js

Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback (Closed)

Patch Set: Address Xianzhu's review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js ('k') | third_party/WebKit/PerformanceTests/Canvas/resources/canvas_runner.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js

diff --git a/third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js b/third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js

index 60d2d2eb1b0a23f4525daab4db49bbed6d864a16..979e4e66e5ec728e9345038a11796167c3a1a47e 100644

--- a/third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js

+++ b/third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js

@@ -14,9 +14,11 @@ if (!window.GCController && !window.gc)

test.unit = 'ms';

if (!test.warmUpCount)

test.warmUpCount = warmUpCount;

+ if (!test.run)

+ test.run = function() {};

completedIterations = 0;

- PerfTestRunner.prepareToMeasureValuesAsync(test);

+ PerfTestRunner.startMeasureValuesAsync(test);

// Force a V8 GC before running Blink GC test to avoid measuring marking from stale V8 wrappers.

if (window.GCController)