third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js - Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js

Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback (Closed)

Patch Set: Address Xianzhu's review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/PerformanceTests/Bindings/post-message.html ('k') | third_party/WebKit/PerformanceTests/BlinkGC/resources/measure-gc.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js

diff --git a/third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js b/third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js

index 1db00f98a6c5017a099574fac088b64aa507c016..f44f460e8367c89c9fe1fe16857b234fb085b7ef 100644

--- a/third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js

+++ b/third_party/WebKit/PerformanceTests/Bindings/resources/structured-clone-perf-test.js

@@ -22,12 +22,13 @@ const StructuredClonePerfTestRunner = (function() {

return {

measureTimeAsync(test) {

let isDone = false;

- PerfTestRunner.prepareToMeasureValuesAsync({

+ PerfTestRunner.startMeasureValuesAsync({

description: test.description,

unit: 'ms',

warmUpCount: test.warmUpCount || 10,

iterationCount: test.iterationCount || 250,

done() { isDone = true; },

+ run: pingPongUntilDone,

});

function pingPongUntilDone() {

@@ -40,7 +41,6 @@ const StructuredClonePerfTestRunner = (function() {

if (!isDone) pingPongUntilDone();

});

}

- pingPongUntilDone();

};

})();