Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: net/nqe/network_quality_estimator_unittest.cc

Issue 2858743002: NQE: Move params from the estimator class to the params class (Closed)
Patch Set: ryansturm comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/network_quality_estimator_params_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator_unittest.cc
diff --git a/net/nqe/network_quality_estimator_unittest.cc b/net/nqe/network_quality_estimator_unittest.cc
index fd73b4b626d9c7100169b303962f3dedb1f74be3..3a1090490c882391eb64a035cd9b65a563ff4ae8 100644
--- a/net/nqe/network_quality_estimator_unittest.cc
+++ b/net/nqe/network_quality_estimator_unittest.cc
@@ -1253,34 +1253,6 @@ TEST(NetworkQualityEstimatorTest, ObtainThresholdsTransportRTTandThroughput) {
}
}
-// Tests if |weight_multiplier_per_second_| is set to correct value for various
-// values of half life parameter.
-TEST(NetworkQualityEstimatorTest, HalfLifeParam) {
- std::map<std::string, std::string> variation_params;
-
- const struct {
- std::string description;
- std::string variation_params_value;
- double expected_weight_multiplier;
- } tests[] = {
- {"Half life parameter is not set, default value should be used",
- std::string(), 0.988},
- {"Half life parameter is set to negative, default value should be used",
- "-100", 0.988},
- {"Half life parameter is set to zero, default value should be used", "0",
- 0.988},
- {"Half life parameter is set correctly", "10", 0.933},
- };
-
- for (const auto& test : tests) {
- variation_params["HalfLifeSeconds"] = test.variation_params_value;
- TestNetworkQualityEstimator estimator(variation_params);
- EXPECT_NEAR(test.expected_weight_multiplier,
- estimator.weight_multiplier_per_second_, 0.001)
- << test.description;
- }
-}
-
TEST(NetworkQualityEstimatorTest, TestGetMetricsSince) {
std::map<std::string, std::string> variation_params;
« no previous file with comments | « net/nqe/network_quality_estimator_params_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698