NQE: Move params from the estimator class to the params class

net/nqe/network_quality_estimator_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/nqe/network_quality_estimator.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 1235 matching lines @@
         test.downlink_throughput_kbps);
     estimator.set_recent_downlink_throughput_kbps(
         test.downlink_throughput_kbps);
     // Run one main frame request to force recomputation of effective connection
     // type.
     estimator.RunOneRequest();
     EXPECT_EQ(test.expected_conn_type, estimator.GetEffectiveConnectionType());
   }
 }
 
-// Tests if |weight_multiplier_per_second_| is set to correct value for various
-// values of half life parameter.
-TEST(NetworkQualityEstimatorTest, HalfLifeParam) {
-  std::map<std::string, std::string> variation_params;
-
-  const struct {
-    std::string description;
-    std::string variation_params_value;
-    double expected_weight_multiplier;
-  } tests[] = {
-      {"Half life parameter is not set, default value should be used",
-       std::string(), 0.988},
-      {"Half life parameter is set to negative, default value should be used",
-       "-100", 0.988},
-      {"Half life parameter is set to zero, default value should be used", "0",
-       0.988},
-      {"Half life parameter is set correctly", "10", 0.933},
-  };
-
-  for (const auto& test : tests) {
-    variation_params["HalfLifeSeconds"] = test.variation_params_value;
-    TestNetworkQualityEstimator estimator(variation_params);
-    EXPECT_NEAR(test.expected_weight_multiplier,
-                estimator.weight_multiplier_per_second_, 0.001)
-        << test.description;
-  }
-}
-
 TEST(NetworkQualityEstimatorTest, TestGetMetricsSince) {
   std::map<std::string, std::string> variation_params;
 
   const base::TimeDelta rtt_threshold_3g =
       base::TimeDelta::FromMilliseconds(30);
   const base::TimeDelta rtt_threshold_4g = base::TimeDelta::FromMilliseconds(1);
 
   variation_params["3G.ThresholdMedianHttpRTTMsec"] =
       base::IntToString(rtt_threshold_3g.InMilliseconds());
   variation_params["HalfLifeSeconds"] = "300000";
@@ skipping 1846 matching lines @@
 
   // Cleanup.
   estimator.RemoveRTTObserver(&rtt_observer);
   estimator.RemoveThroughputObserver(&throughput_observer);
   estimator.RemoveRTTAndThroughputEstimatesObserver(&rtt_throughput_observer);
   estimator.RemoveEffectiveConnectionTypeObserver(
       &effective_connection_type_observer);
 }
 
 }  // namespace net