Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2858693003: Remove the deprecated cipher fallback. (Closed)

Created:
3 years, 7 months ago by davidben
Modified:
3 years, 7 months ago
Reviewers:
Mark P, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, net-reviews_chromium.org, bnc+watch_chromium.org, asvitkine+watch_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the deprecated cipher fallback. This is currently unused. BUG=684730 Review-Url: https://codereview.chromium.org/2858693003 Cr-Commit-Position: refs/heads/master@{#470600} Committed: https://chromium.googlesource.com/chromium/src/+/6b2bb1cab86b205b3b29f3e3ec4e3db2a9b18196

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -128 lines) Patch
M net/http/http_network_transaction.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 4 chunks +0 lines, -43 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 1 chunk +1 line, -6 lines 2 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M net/ssl/ssl_config.h View 1 chunk +0 lines, -13 lines 0 comments Download
M net/ssl/ssl_config.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (23 generated)
davidben
https://codereview.chromium.org/2858693003/diff/40001/net/socket/client_socket_pool_manager.cc File net/socket/client_socket_pool_manager.cc (right): https://codereview.chromium.org/2858693003/diff/40001/net/socket/client_socket_pool_manager.cc#newcode117 net/socket/client_socket_pool_manager.cc:117: connection_group = "ssl/" + connection_group; There. Happy now? :-)
3 years, 7 months ago (2017-05-09 19:04:18 UTC) #16
mmenke
LGTM! https://codereview.chromium.org/2858693003/diff/40001/net/socket/client_socket_pool_manager.cc File net/socket/client_socket_pool_manager.cc (right): https://codereview.chromium.org/2858693003/diff/40001/net/socket/client_socket_pool_manager.cc#newcode117 net/socket/client_socket_pool_manager.cc:117: connection_group = "ssl/" + connection_group; On 2017/05/09 19:04:18, ...
3 years, 7 months ago (2017-05-09 19:34:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858693003/40001
3 years, 7 months ago (2017-05-09 21:03:18 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/265555)
3 years, 7 months ago (2017-05-09 21:30:43 UTC) #21
davidben
CQ is sad, but apparently I'm missing a histograms.xml stamp anyway. +mpearson
3 years, 7 months ago (2017-05-09 22:47:11 UTC) #23
Mark P
histograms.xml lgtm
3 years, 7 months ago (2017-05-09 22:48:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858693003/40001
3 years, 7 months ago (2017-05-09 22:51:41 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/174288)
3 years, 7 months ago (2017-05-09 23:28:34 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858693003/40001
3 years, 7 months ago (2017-05-10 15:15:02 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:31:02 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6b2bb1cab86b205b3b29f3e3ec4e...

Powered by Google App Engine
This is Rietveld 408576698