UKM debug page

Adds a UKM debug page at chrome://ukm

BUG=718674
Review-Url: https://codereview.chromium.org/2858683006
Cr-Commit-Position: refs/heads/master@{#471084}
Committed: https://chromium.googlesource.com/chromium/src/+/da176b49eafe0f94f32919620f7ea6fb3e0d808f

[Steven Holte, 2017-05-05 02:08:31]

holte@chromium.org changed reviewers:
+ asvitkine@google.com

[Steven Holte, 2017-05-05 02:10:32]

Description was changed from

==========
UKM debug page

BUG=
==========

to

==========
Adds a UKM debug page at chrome://ukm

BUG=718674
==========

[Steven Holte, 2017-05-05 02:10:44]

holte@chromium.org changed reviewers:
+ asvitkine@chromium.org
- asvitkine@google.com

[Alexei Svitkine (slow), 2017-05-05 16:45:05]

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
File components/ukm/debug_page/debug_page.cc (right):

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.cc:31: void DebugPage::StartDataRequest(
Could you add a reviewer who's familiar with this infrastructure as well?

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
File components/ukm/debug_page/debug_page.h (right):

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:15: class UkmService;
Nit: Add an empty line before this.

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:19: class DebugPage : public
content::URLDataSource {
Add a comment.

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:23: DebugPage(ServiceGetter
service_getter);
Nit: explicit

[Steven Holte, 2017-05-05 18:16:43]

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
File components/ukm/debug_page/debug_page.cc (right):

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.cc:31: void DebugPage::StartDataRequest(
On 2017/05/05 16:45:04, Alexei Svitkine (slow) wrote:
> Could you add a reviewer who's familiar with this infrastructure as well?

Sure.

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
File components/ukm/debug_page/debug_page.h (right):

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:15: class UkmService;
On 2017/05/05 16:45:05, Alexei Svitkine (slow) wrote:
> Nit: Add an empty line before this.

Done.

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:19: class DebugPage : public
content::URLDataSource {
On 2017/05/05 16:45:05, Alexei Svitkine (slow) wrote:
> Add a comment.

Done.

https://codereview.chromium.org/2858683006/diff/20001/components/ukm/debug_pa...
components/ukm/debug_page/debug_page.h:23: DebugPage(ServiceGetter
service_getter);
On 2017/05/05 16:45:05, Alexei Svitkine (slow) wrote:
> Nit: explicit

Done.

[Steven Holte, 2017-05-05 18:17:20]

holte@chromium.org changed reviewers:
+ jam@chromium.org

[Steven Holte, 2017-05-05 18:17:20]

+jam for usage of content::URLDataSource

[Alexei Svitkine (slow), 2017-05-05 18:46:03]

lgtm

[jam, 2017-05-08 15:02:56]

lgtm

[Steven Holte, 2017-05-08 18:04:25]

The CQ bit was checked by holte@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:05:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:12:00]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Steven Holte, 2017-05-08 18:28:42]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-05-08 18:28:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2858683006/#ps60001
(title: "Fix Deps")

[commit-bot: I haz the power, 2017-05-08 18:29:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:41:14]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Steven Holte, 2017-05-08 19:51:03]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 19:52:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:04:54]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Steven Holte, 2017-05-08 20:40:30]

The CQ bit was checked by holte@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:41:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:52:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Steven Holte, 2017-05-11 19:19:03]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-05-11 19:19:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2858683006/#ps140001
(title: "Seperate BUILD file")

[commit-bot: I haz the power, 2017-05-11 19:19:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 21:58:19]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494530343602510,
"parent_rev": "353cd8d6cae31aa1175ae20d77649672f84bf3d5", "commit_rev":
"da176b49eafe0f94f32919620f7ea6fb3e0d808f"}

[commit-bot: I haz the power, 2017-05-11 21:58:35]

Description was changed from

==========
Adds a UKM debug page at chrome://ukm

BUG=718674
==========

to

==========
Adds a UKM debug page at chrome://ukm

BUG=718674

Review-Url: https://codereview.chromium.org/2858683006
Cr-Commit-Position: refs/heads/master@{#471084}
Committed:
https://chromium.googlesource.com/chromium/src/+/da176b49eafe0f94f32919620f7e...
==========

[commit-bot: I haz the power, 2017-05-11 21:58:36]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/da176b49eafe0f94f32919620f7e...