Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2858683004: Add LOG for when IOSurface allocation fails (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
ericrk
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add LOG for when IOSurface allocation fails This is somewhat catastrophic (it results in blank contents or black tiles), so be sure that it is captured in about:gpu. BUG=574014 Review-Url: https://codereview.chromium.org/2858683004 Cr-Commit-Position: refs/heads/master@{#469382} Committed: https://chromium.googlesource.com/chromium/src/+/13f3aa8a8bcc07bd5a23f4bb1cac65fd82da9038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gfx/mac/io_surface.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
ccameron
Probably a thing worth knowing about...
3 years, 7 months ago (2017-05-03 15:34:05 UTC) #6
ericrk
LGTM!
3 years, 7 months ago (2017-05-04 00:33:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683004/1
3 years, 7 months ago (2017-05-04 15:05:18 UTC) #9
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 7 months ago (2017-05-04 16:05:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683004/1
3 years, 7 months ago (2017-05-04 18:04:38 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:15:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13f3aa8a8bcc07bd5a23f4bb1cac...

Powered by Google App Engine
This is Rietveld 408576698