Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2858653002: Adjust error message position (Closed)

Created:
3 years, 7 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust error message position When anchoring the error message bubble, hidden pin container should not take up space. BUG=712628 Review-Url: https://codereview.chromium.org/2858653002 Cr-Commit-Position: refs/heads/master@{#470830} Committed: https://chromium.googlesource.com/chromium/src/+/267eca9a18e9706891407c5d31f2160700d04ba7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/login/account_picker/screen_account_picker.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Wenzhao (Colin) Zang
alemate@, jdufault@: please take a look at this small change. The bug is a regression ...
3 years, 7 months ago (2017-05-02 18:39:31 UTC) #3
jdufault
lgtm, thanks
3 years, 7 months ago (2017-05-02 20:39:06 UTC) #4
Wenzhao (Colin) Zang
alemate@, is the change OK? Thanks.
3 years, 7 months ago (2017-05-09 21:12:33 UTC) #5
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-10 22:37:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858653002/1
3 years, 7 months ago (2017-05-11 05:34:03 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:49:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/267eca9a18e9706891407c5d31f2...

Powered by Google App Engine
This is Rietveld 408576698