Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2858633004:
[Extensions Bindings] Fix uninitialized member in ArgumentSpec (Closed)
Description[Extensions Bindings] Fix uninitialized member in ArgumentSpec
BUG=653596
Review-Url: https://codereview.chromium.org/2858633004
Cr-Commit-Position: refs/heads/master@{#468870}
Committed: https://chromium.googlesource.com/chromium/src/+/5fc690195ffb3cda28fb0ad3ed5f60093f9ec508
Patch Set 1 #
Total comments: 2
Patch Set 2 : d'oh #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rdevlin.cronin@chromium.org changed reviewers: + jbroman@chromium.org, lazyboy@chromium.org
lgtm
The CQ bit was unchecked by rdevlin.cronin@chromium.org
The CQ bit was checked by rdevlin.cronin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2858633004/diff/1/extensions/renderer/argumen... File extensions/renderer/argument_spec.cc (right): https://codereview.chromium.org/2858633004/diff/1/extensions/renderer/argumen... extensions/renderer/argument_spec.cc:84: ArgumentSpec::ArgumentSpec(ArgumentType type) {} Ah might have deleted too much here.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rdevlin.cronin@chromium.org
https://codereview.chromium.org/2858633004/diff/1/extensions/renderer/argumen... File extensions/renderer/argument_spec.cc (right): https://codereview.chromium.org/2858633004/diff/1/extensions/renderer/argumen... extensions/renderer/argument_spec.cc:84: ArgumentSpec::ArgumentSpec(ArgumentType type) {} On 2017/05/03 00:24:57, lazyboy wrote: > Ah might have deleted too much here. ...d'oh.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org, jbroman@chromium.org Link to the patchset: https://codereview.chromium.org/2858633004/#ps20001 (title: "d'oh")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493774001189790,
"parent_rev": "f8bfab30bb6ee9f95277a16ee02bc930da2b2a2a", "commit_rev":
"5fc690195ffb3cda28fb0ad3ed5f60093f9ec508"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions Bindings] Fix uninitialized member in ArgumentSpec BUG=653596 ========== to ========== [Extensions Bindings] Fix uninitialized member in ArgumentSpec BUG=653596 Review-Url: https://codereview.chromium.org/2858633004 Cr-Commit-Position: refs/heads/master@{#468870} Committed: https://chromium.googlesource.com/chromium/src/+/5fc690195ffb3cda28fb0ad3ed5f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5fc690195ffb3cda28fb0ad3ed5f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
