Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2858583002: Fix crash when pressing stylus tools accelerator with null PaletteTray. (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
James Cook, jdufault
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when pressing stylus tools accelerator with null PaletteTray. BUG=717422 Review-Url: https://codereview.chromium.org/2858583002 Cr-Commit-Position: refs/heads/master@{#468651} Committed: https://chromium.googlesource.com/chromium/src/+/be86e8abc1a85b3cdb7b575ed1f5d6a6bbbfd460

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Evan Stade
palette_tray_ is created conditionally so I guess it can be null in some scenario (clusterfuzz ...
3 years, 7 months ago (2017-05-02 15:18:43 UTC) #2
James Cook
LGTM. I just filed a bug for the underlying issue, crbug.com/717559 - but I think ...
3 years, 7 months ago (2017-05-02 15:37:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858583002/20001
3 years, 7 months ago (2017-05-02 15:50:11 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:58:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be86e8abc1a85b3cdb7b575ed1f5...

Powered by Google App Engine
This is Rietveld 408576698