Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2858563002: Revert of chromeos: Makes mushrome use simplified display management (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
kylechar, sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Makes mushrome use simplified display management (patchset #8 id:140001 of https://codereview.chromium.org/2840043003/ ) Reason for revert: This appears to have broken https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/46388, and that bot has mus_browser_test failing reliably since then. More info on the associated bug: BUG=717523 Original issue's description: > chromeos: Makes mushrome use simplified display management > > This also adds a stanalone_ash target that is the equivalent of > ash_shell_with_content but running in mushrome mode and without > content. > > BUG=708287, 706589 > TEST=covered by tests > R=kylechar@chromium.org > > Review-Url: https://codereview.chromium.org/2840043003 > Cr-Commit-Position: refs/heads/master@{#468123} > Committed: https://chromium.googlesource.com/chromium/src/+/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5 TBR=kylechar@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=708287, 706589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -496 lines) Patch
M ash/aura/shell_port_classic.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 4 chunks +5 lines, -22 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 2 chunks +12 lines, -21 lines 0 comments Download
M ash/host/transformer_helper.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ash/mus/ash_window_tree_host_mus.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ash/mus/ash_window_tree_host_mus.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M ash/mus/bridge/shell_port_mash.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/bridge/shell_port_mash.cc View 9 chunks +8 lines, -92 lines 0 comments Download
M ash/mus/main.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/mus/test/ash_test_impl_mus.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ash/mus/test/wm_test_base.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M ash/mus/test/wm_test_helper.cc View 7 chunks +5 lines, -23 lines 0 comments Download
M ash/mus/window_manager.h View 2 chunks +1 line, -7 lines 0 comments Download
M ash/mus/window_manager.cc View 4 chunks +12 lines, -23 lines 0 comments Download
M ash/mus/window_manager_application.h View 5 chunks +1 line, -22 lines 0 comments Download
M ash/mus/window_manager_application.cc View 5 chunks +5 lines, -20 lines 0 comments Download
M ash/shell.cc View 6 chunks +29 lines, -21 lines 0 comments Download
M ash/shell_init_params.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/embedded_services.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M services/ui/display/screen_manager_forwarding.cc View 1 chunk +1 line, -4 lines 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +2 lines, -29 lines 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vabr (Chromium)
Created Revert of chromeos: Makes mushrome use simplified display management
3 years, 7 months ago (2017-05-02 13:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858563002/1
3 years, 7 months ago (2017-05-02 13:38:50 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 13:41:49 UTC) #5
Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698