Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2858553002: use USVString for URLs at CSSURLImageValue. (Closed)

Created:
3 years, 7 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

use USVString for URLs at CSSURLImageValue. use USVString for URLs instead of DOMString at CSSURLImageValue.idl. https://drafts.css-houdini.org/css-typed-om-1/#cssurlimagevalue https://github.com/w3c/css-houdini-drafts/issues/244 BUG=545318 Review-Url: https://codereview.chromium.org/2858553002 Cr-Commit-Position: refs/heads/master@{#468906} Committed: https://chromium.googlesource.com/chromium/src/+/45a7c2276c2fd1dfed024ec74bdb0c2417a73114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-02 14:01:56 UTC) #8
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-03 03:29:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858553002/1
3 years, 7 months ago (2017-05-03 06:33:17 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 06:36:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45a7c2276c2fd1dfed024ec74bdb...

Powered by Google App Engine
This is Rietveld 408576698