Issue 2858523002: Merged: [heap] Filter out non-heap values when tracing wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2858523002: Merged: [heap] Filter out non-heap values when tracing wrappers (Closed)

Created:
3 years, 7 months ago by Michael Lippautz

Modified:
3 years, 7 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan, Hannes Payer (out of office)

Target Ref:
refs/branch-heads/5.9

Project:
v8

Visibility:
Public.

Merged: [heap] Filter out non-heap values when tracing wrappers Revision: 1f3a95f1f7a11ba7a97901ea6046c251ef77bed4 BUG=chromium:716031 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2858523002 . Cr-Commit-Position: refs/branch-heads/5.9@{#35} Cr-Branched-From: fe9bb7e6e251159852770160cfb21dad3cf03523-refs/heads/5.9.211@{#1} Cr-Branched-From: 70ad23791a21c0dd7ecef8d4d8dd30ff6fc291f6-refs/heads/master@{#44591} Committed: https://chromium.googlesource.com/v8/v8/+/c2a7a031b854cc5bf7be84554f1d0824704c6100

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/heap/heap.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Michael Lippautz

3 years, 7 months ago (2017-05-02 08:57:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2a7a031b854cc5bf7be84554f1d0824704c6100.