Chromium Code Reviews| Index: chrome/test/data/webui/md_bookmarks/test_store.js |
| diff --git a/chrome/test/data/webui/md_bookmarks/test_store.js b/chrome/test/data/webui/md_bookmarks/test_store.js |
| index 749b9bcd3d5b3522dba0de0c71656b1cf6ed188e..5d85e447f0c9b10f45be8100d11c47e8f7202f4a 100644 |
| --- a/chrome/test/data/webui/md_bookmarks/test_store.js |
| +++ b/chrome/test/data/webui/md_bookmarks/test_store.js |
| @@ -52,11 +52,13 @@ suiteSetup(function() { |
| bookmarks.Store.prototype.reduce_.call(this, action); |
| }, |
| + /** |
| + * Notifies UI elements that the store data has changed. When reducers are |
| + * disabled, tests are responsible for manually changing the data to make |
| + * UI elements update correctly (eg, tests must replace the whole list |
| + * when changing a single element). |
|
tsergeant
2017/05/02 05:09:10
It's been long enough to convince me that we don't
calamity
2017/05/02 05:35:59
Agreed. I don't foresee any other major data membe
|
| + */ |
| notifyObservers: function() { |
| - // TODO(tsergeant): Revisit how state modifications work in UI tests. |
| - // We don't want tests to worry about modifying the whole state tree. |
| - // Instead, we could perform a deep clone in here to ensure that every |
| - // StoreClient is updated. |
| this.notifyObservers_(this.data); |
| }, |