Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: chrome/browser/resources/md_bookmarks/store_client.js

Issue 2858483002: MD Bookmarks: Update a couple of TODOs (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/store_client.js
diff --git a/chrome/browser/resources/md_bookmarks/store_client.js b/chrome/browser/resources/md_bookmarks/store_client.js
index 7d1512734967740a7b2c1f51f90ab171bc17bd8a..6cea153d2f3231cbf5817df3b4a1425e45ad4a8a 100644
--- a/chrome/browser/resources/md_bookmarks/store_client.js
+++ b/chrome/browser/resources/md_bookmarks/store_client.js
@@ -49,7 +49,10 @@ cr.define('bookmarks', function() {
* @param {function(!BookmarksPageState)} valueGetter
*/
watch: function(localProperty, valueGetter) {
- // TODO(tsergeant): Warn if localProperty is not a defined property.
+ if (!this.getPropertyInfo(localProperty).defined) {
tsergeant 2017/05/02 05:09:10 I originally TODO'd this because I thought it woul
calamity 2017/05/02 05:35:59 Heh. Polymer 2.0: Removed APIs - element.getPrope
tsergeant 2017/05/02 05:41:56 😔
+ console.error(
+ 'No property ' + localProperty + ' defined on ' + this.is);
+ }
this.watches_.push({
localProperty: localProperty,
valueGetter: valueGetter,
« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/test_store.js » ('j') | chrome/test/data/webui/md_bookmarks/test_store.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698