Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

Issue 2858433002: [Android] Increase the clickable area of direct share icon (Closed)
Patch Set: Udpate based on Ted's comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
index ef2f4045d44f2e15830f6edfdb156473718425eb..3c39b20db46cedf60b2726c5d7588ca1109bee20 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
@@ -12,6 +12,7 @@ import android.view.View;
import android.view.ViewGroup;
import android.widget.BaseAdapter;
import android.widget.ImageView;
+import android.widget.Space;
import android.widget.TextView;
import org.chromium.chrome.R;
@@ -69,6 +70,8 @@ class TabularContextMenuListAdapter extends BaseAdapter {
viewHolder.mText = (TextView) convertView.findViewById(R.id.context_text);
viewHolder.mShareIcon =
(ImageView) convertView.findViewById(R.id.context_menu_share_icon);
+ viewHolder.mRightPadding =
+ (Space) convertView.findViewById(R.id.context_menu_right_padding);
convertView.setTag(viewHolder);
} else {
@@ -94,6 +97,7 @@ class TabularContextMenuListAdapter extends BaseAdapter {
mOnShareItemClicked.run();
}
});
+ viewHolder.mRightPadding.setVisibility(View.GONE);
Ted C 2017/05/02 21:06:47 you need to set this to VISIBLE in the else case b
ltian 2017/05/03 19:05:05 Done.
}
} else {
viewHolder.mShareIcon.setVisibility(View.GONE);
@@ -106,5 +110,6 @@ class TabularContextMenuListAdapter extends BaseAdapter {
ImageView mIcon;
TextView mText;
ImageView mShareIcon;
+ Space mRightPadding;
}
}

Powered by Google App Engine
This is Rietveld 408576698