[Android] Increase the clickable area of direct share icon

chrome/android/java/res/layout/tabular_context_menu_row.xml

Index: chrome/android/java/res/layout/tabular_context_menu_row.xml
diff --git a/chrome/android/java/res/layout/tabular_context_menu_row.xml b/chrome/android/java/res/layout/tabular_context_menu_row.xml
index 5e4d200f2fdc6f3857bf2a00043407c70c884dd9..1feec1a974f4515389c54360a58abe0166bddcf9 100644
--- a/chrome/android/java/res/layout/tabular_context_menu_row.xml
+++ b/chrome/android/java/res/layout/tabular_context_menu_row.xml
@@ -8,13 +8,14 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:paddingStart="15dp"
-    android:paddingEnd="15dp"
     android:minHeight="40dp"
     tools:ignore="UseCompoundDrawables">
     <ImageView
         android:id="@+id/context_menu_icon"
         android:layout_width="20dp"
         android:layout_height="20dp"
+        android:layout_marginTop="10dp"

[Ted C, 2017/05/02 21:06:47]

are these strictly necessary?  And by setting top and bottom margins, doesn't
this make the available height 0?

20 - 10 - 10 == 0

[ltian, 2017/05/03 19:05:05]

There are the settings in spec. The margin is placed outside the view so the
whole height is 20 + 10 + 10 = 40. I can change it to use padding and the
layout_height = 40 dp. Since this ImageView does not register for OnClick
listener, I think there is no difference between these two options.

+        android:layout_marginBottom="10dp"
         android:layout_gravity="center_vertical"

[Ted C, 2017/05/02 21:06:47]

if we need margins, is this needed anymore?

[ltian, 2017/05/03 19:05:05]

Oh, then both two ImageViews should not need this.

         android:contentDescription="@null" />
     <TextView
@@ -28,9 +29,17 @@
         android:textColor="#dd000000" />
     <ImageView
         android:id="@+id/context_menu_share_icon"
-        android:layout_width="20dp"
-        android:layout_height="20dp"
+        android:layout_width="51dp"
+        android:layout_height="40dp"

[Ted C, 2017/05/02 21:06:47]

We should probably sync with UX, but what happens when the user bumps up their
font size?  In that case, the total row height could be taller than 40dp. 
Should we center the image in that case?

I'm wondering if layout_height should be MATCH_PARENT then we could just set
android:scaleType to something like centerInside.

[ltian, 2017/05/03 19:05:05]

Done.

+        android:paddingTop="8dp"
+        android:paddingBottom="8dp"
+        android:paddingStart="12dp"
+        android:paddingEnd="15dp"
         android:layout_gravity="center_vertical"
         android:contentDescription="@null"
         android:visibility="gone"/>
+    <Space
+        android:id="@+id/context_menu_right_padding"
+        android:layout_width="15dp"
+        android:layout_height="wrap_content"/>
 </LinearLayout>