chrome/android/java/res/layout/tabular_context_menu_row.xml - Issue 2858433002: [Android] Increase the clickable area of direct share icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/tabular_context_menu_row.xml

Issue 2858433002: [Android] Increase the clickable area of direct share icon (Closed)

Patch Set: Add design spec in the description. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/tabular_context_menu_row.xml

diff --git a/chrome/android/java/res/layout/tabular_context_menu_row.xml b/chrome/android/java/res/layout/tabular_context_menu_row.xml

index 5e4d200f2fdc6f3857bf2a00043407c70c884dd9..3b4a3fe0f33c17a55f84c92dfa9870be6e0c0d57 100644

--- a/chrome/android/java/res/layout/tabular_context_menu_row.xml

+++ b/chrome/android/java/res/layout/tabular_context_menu_row.xml

@@ -4,17 +4,18 @@

found in the LICENSE file. -->

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

xmlns:tools="http://schemas.android.com/tools"

+ android:id="@+id/context_menu_row"

android:orientation="horizontal"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:paddingStart="15dp"

- android:paddingEnd="15dp"

android:minHeight="40dp"

tools:ignore="UseCompoundDrawables">

<ImageView

android:id="@+id/context_menu_icon"

android:layout_width="20dp"

android:layout_height="20dp"

+ android:layout_marginTop="10dp"

+ android:layout_marginBottom="10dp"

android:layout_gravity="center_vertical"

android:contentDescription="@null" />

<TextView

@@ -28,8 +29,11 @@

android:textColor="#dd000000" />

<ImageView

android:id="@+id/context_menu_share_icon"

- android:layout_width="20dp"

- android:layout_height="20dp"

+ android:layout_width="24dp"

+ android:layout_height="24dp"

+ android:layout_marginTop="8dp"

Ted C 2017/05/02 16:51:37 do you want margin or padding? Margin is likely r

ltian 2017/05/02 18:52:28 Sorry I just learn that padding is clickable while

+ android:layout_marginBottom="8dp"

+ android:layout_marginEnd="15dp"

Ted C 2017/05/02 16:51:37 according to the spec, you also need 12dp start pa

ltian 2017/05/02 18:52:28 Done.

android:layout_gravity="center_vertical"

android:contentDescription="@null"

android:visibility="gone"/>