[Android] Increase the clickable area of direct share icon

chrome/android/java/res/layout/tabular_context_menu_row.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
+    android:id="@+id/context_menu_row"
     android:orientation="horizontal"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:paddingStart="15dp"
-    android:paddingEnd="15dp"
     android:minHeight="40dp"
     tools:ignore="UseCompoundDrawables">
     <ImageView
         android:id="@+id/context_menu_icon"
         android:layout_width="20dp"
         android:layout_height="20dp"
+        android:layout_marginTop="10dp"
+        android:layout_marginBottom="10dp"
         android:layout_gravity="center_vertical"
         android:contentDescription="@null" />
     <TextView
         android:id="@+id/context_text"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_gravity="center_vertical"
         android:layout_marginStart="10dp"

[Ted C, 2017/05/02 16:51:37]

I think you should also add 15dp marginEnd here.  The somewhat annoying thing is
that we always want 15dp space at the end.  But here you need to conditionally
put it based on whether the share icon exists.

You could also add a <Space/> view with 15dp width that you hide or show based
on the context menu.

[ltian, 2017/05/02 18:52:28]

Done.

         android:layout_weight="1"
         android:textSize="15sp"
         android:textColor="#dd000000" />
     <ImageView
         android:id="@+id/context_menu_share_icon"
-        android:layout_width="20dp"
-        android:layout_height="20dp"
+        android:layout_width="24dp"
+        android:layout_height="24dp"
+        android:layout_marginTop="8dp"

[Ted C, 2017/05/02 16:51:37]

do you want margin or padding?  Margin is likely reducing your click target
size.

[ltian, 2017/05/02 18:52:28]

Sorry I just learn that padding is clickable while margin is not. So definitely
padding is the right choice to use. Thanks!

+        android:layout_marginBottom="8dp"
+        android:layout_marginEnd="15dp"

[Ted C, 2017/05/02 16:51:37]

according to the spec, you also need 12dp start padding/margin

[ltian, 2017/05/02 18:52:28]

Done.

         android:layout_gravity="center_vertical"
         android:contentDescription="@null"
         android:visibility="gone"/>
 </LinearLayout>