Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2858403002:
Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. (Closed)
|
Created:
3 years, 7 months ago by karandeepb Modified:
3 years, 7 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExtensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated.
This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules
histogram that tracks whether a network request from a guest <webview> has any
declarative web request rules to be evaluated.
This should help us gather data regarding how often the declarative web request
API is used by webviews and to decide a future course of action for the API once
Declarative Net Request is launched.
BUG=696822
Review-Url: https://codereview.chromium.org/2858403002
Cr-Commit-Position: refs/heads/master@{#469842}
Committed: https://chromium.googlesource.com/chromium/src/+/8f1d69227086e739c76da1a22a17134980cb4f6b
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Clarify histogram description. #
Messages
Total messages: 29 (19 generated)
Description was changed from ========== -- BUG= ========== to ========== Extensions: Add UMA to monitor whether a webview request has applicable DWR rules. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any applicable declarative web request rules to be processed. BUG=696822 ==========
karandeepb@chromium.org changed reviewers: + lazyboy@chromium.org
PTAL Istiaque. Do you have ideas on other good metrics to collect for measuring DWR usage?
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2858403002/diff/20001/extensions/browser/api/... File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/2858403002/diff/20001/extensions/browser/api/... extensions/browser/api/web_request/web_request_api.cc:2005: "Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules", relevant_registries.empty() == true doesn't necessarily mean that webview has applicable rules, it only means it might have applicable rules in the registry, right? Because if deltas_created is false below, then it wouldn't have any rules to apply. I'd change the description/name in relevant places to reflect that. Also I'd be clear about the motivation of this UMA in CL description.
Description was changed from ========== Extensions: Add UMA to monitor whether a webview request has applicable DWR rules. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any applicable declarative web request rules to be processed. BUG=696822 ========== to ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be processed. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be processed. This should help us gather data regarding how often the declarative web request APIs are used by webviews. BUG=696822 ==========
Patchset #3 (id:40001) has been deleted
Description was changed from ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be processed. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be processed. This should help us gather data regarding how often the declarative web request APIs are used by webviews. BUG=696822 ========== to ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be evaluated. This should help us gather data regarding how often the declarative web request APIs are used by webviews. BUG=696822 ==========
Description was changed from ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be evaluated. This should help us gather data regarding how often the declarative web request APIs are used by webviews. BUG=696822 ========== to ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be evaluated. This should help us gather data regarding how often the declarative web request API is used by webviews and to decide a future course of action for the API once Declarative Net Request is launched. BUG=696822 ==========
Patchset #3 (id:60001) has been deleted
PTAL Istiaque. https://codereview.chromium.org/2858403002/diff/20001/extensions/browser/api/... File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/2858403002/diff/20001/extensions/browser/api/... extensions/browser/api/web_request/web_request_api.cc:2005: "Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules", On 2017/05/05 17:46:45, lazyboy wrote: > relevant_registries.empty() == true doesn't necessarily mean that webview has > applicable rules, it only means it might have applicable rules in the registry, > right? Because if deltas_created is false below, then it wouldn't have any rules > to apply. > I'd change the description/name in relevant places to reflect that. > > Also I'd be clear about the motivation of this UMA in CL description. Have removed the usage of the word applicable and changed it to clarify that the request has rules that need to be evaluated. Have also updated the CL description.
lgtm
karandeepb@chromium.org changed reviewers: + isherman@chromium.org
+isherman@ for histograms review.
Metrics LGTM, thanks.
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494027373590010,
"parent_rev": "c3c6e3d369c0d2246d3e63eec0cddd12b7eaee2a", "commit_rev":
"47ff582d9d1882c1ccb24942bde058b0f1ddd11c"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494027373590010,
"parent_rev": "3bc10712ccd6bce8943dbf83df465acad4e7e4e2", "commit_rev":
"65ae148be22de13ebb457056a271c9a549b42e46"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494027373590010,
"parent_rev": "7d028ffb7e580605ae2182842f8fe0c611777523", "commit_rev":
"8f1d69227086e739c76da1a22a17134980cb4f6b"}
Message was sent while issue was closed.
Description was changed from ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be evaluated. This should help us gather data regarding how often the declarative web request API is used by webviews and to decide a future course of action for the API once Declarative Net Request is launched. BUG=696822 ========== to ========== Extensions: Add UMA to monitor whether a webview request has DWR rules to be evaluated. This CL adds Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules histogram that tracks whether a network request from a guest <webview> has any declarative web request rules to be evaluated. This should help us gather data regarding how often the declarative web request API is used by webviews and to decide a future course of action for the API once Declarative Net Request is launched. BUG=696822 Review-Url: https://codereview.chromium.org/2858403002 Cr-Commit-Position: refs/heads/master@{#469842} Committed: https://chromium.googlesource.com/chromium/src/+/8f1d69227086e739c76da1a22a17... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/8f1d69227086e739c76da1a22a17... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
